[MERGE] selftest: use SymlinkFeature instead of TestSkipped where appropriate
John Arbash Meinel
john at arbash-meinel.com
Thu Nov 1 14:02:51 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Alexander Belchenko wrote:
> These changes are mostly mechanical.
>
> Alexander
>
BB:tweak
if getattr(os, 'mkfifo', None) is None:
- - # TODO: Ultimately this should be TestSkipped
- - # or PlatformDeficiency
- - return
+ raise TestSkipped('OS does not support mkfifo')
^- I think we want a comment that this should be an 'UnavailableFeature'
+ raise TestSkipped('pycurl do not check HTTP_PROXY '
+ 'for security reasons')
^- This should be: pycurl does not ...
(including in the nearby comment.)
The rest looks good.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHKdyKJdeBCYSNAAMRAiGyAKCddW9ABtnI1UMNdhYS0SRR3UTKvQCfQXwm
1FgoJbw0JscFrd1e3U7R4/M=
=luu3
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list