bzr crash dump

John Arbash Meinel john at arbash-meinel.com
Wed Oct 31 22:20:10 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Wed, 2007-10-31 at 17:10 -0500, John Arbash Meinel wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>>
>> ...
>>
>>> KnitCorrupt: Knit <bzrlib.knit._KnitAccess object at 0x221dcf0> corrupt:
>>  While reading {rjk at greenend.org.uk-20071030230320-797aee3fd4927253} got IOError(CRC check failed 1569738316 2371602488)
>>
>> Robert, as an aside, this is why I wanted _KnitAccess to have a filename, if
>> you remember our earlier discussions. You felt like it was clumsy to pass it
>> through the various layers, but it means that when we get a corrupted .knit
>> object, we can know which one it is.
> 
> I think it's fine for _KnitAccess to have a filename. I thought at the
> time that you were asking for _PackAccess and KnitGraphIndex, where it
> really is problematic. 

I think we're going to want to overcome that somehow, though. While packs won't
be appended to like knits, that doesn't mean we won't ever get corrupted data
in them. And debugging that is a lot easier when you have filenames to deal with.

> 
> I'll be happy to come back to this and do it once I have the packs
> critical bugs fixed.
> 
> -Rob

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHKP+aJdeBCYSNAAMRAgqzAKCd6Aa5cDjzg9XV/7cFg+vWfBzzHwCfYmDa
GcNtZyWu7PIrQZa2cNDC3a4=
=9/X7
-----END PGP SIGNATURE-----



More information about the bazaar mailing list