[MERGE] Branch.open_containing_from_transport() (was Re: [MERGE] Make pull more forgiving of its location)

Aaron Bentley aaron.bentley at utoronto.ca
Tue Oct 30 11:33:08 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew D. Fuller wrote:
> On Thu, Sep 13, 2007 at 03:11:52PM -0400 I heard the voice of
> Aaron Bentley, and lo! it spake thus:
>> Comment:
>> It would have been nice to make Branch.open_containing_from_transport
> 
> Well, as long as the pull patch is on held, I took a glance at this.
> Attacked trivial bundle adds the function.

Actually, now that open_containing takes a possible_transports
parameter, we can use it:

Branch.open_containing(location,
                       possible_transports=[location_transport])

> No tests are included.
> But then, there aren't any tests for Branch.open_from_transport()
> either (and there barely is for Branch.open_containing() for that
> matter), so I don't have any real guidance on where one would go.

It would typically go in bzrlib/tests/test_branch.py

We should always be working to increase test coverage, so I'll ask you
to resubmit, if you like the separate function's worth it.

bb:resubmit

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHJxZ00F+nu1YWqI0RAp8WAJ93yJRZZn08i6E1xWE4uN7sB8u71wCfd8dF
OLr971+rTXeXO/WOuHNuekQ=
=FVQi
-----END PGP SIGNATURE-----



More information about the bazaar mailing list