[MERGE 157789] Updated pack progress bar patch

[Martin Pool]

+        pb = ui.ui_factory.nested_progress_bar()
+        try:
+            return self._create_pack_from_packs(packs, suffix, revision_ids,
+                pb)
+        finally:
+            pb.finished()

(comment) This is ok because it's consistent with what we normally do,
but I'm not sure we really should be finishing progress bars from
finally blocks.  If we have terminated because of an error or
interrupt, clearing the bar may obscure something either on the screen
or in the traceback.

It would also remove the introduction of extra call layers.

+        pb.update("Opening pack", 0, 5)
+        pb.update("Copying revision texts.", 1)

Some of them have final periods and some do not.  I think the general
style is for them not to?

On 10/29/07, Bundle Buggy <bundlebuggy at aaronbentley.com> wrote:
> Bundle Buggy has detected this merge request.
>
> For details, see:
> http://bundlebuggy.aaronbentley.com/request/%3C1193665080.6724.22.camel%40lifeless-64%3E
>
>


-- 
Martin