[MERGE] remove auto-lock decorators from add_inventory and add_revision
John Arbash Meinel
john at arbash-meinel.com
Sat Oct 27 17:56:49 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool wrote:
> Two good reasons to remove them: they're quite low-level operations
> likely to already be inside a write group, and and they require a write
> group so won't work anyhow if called without a write lock.
>
> (NEWS needs to be updated post 0.92)
On the flip side, they aren't called many times (1 time per revision),
so it doesn't really hurt much.
I agree that it is unlikely to be an actual problem, though. So if you
feel like it is important:
BB:approve
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHI23RJdeBCYSNAAMRAqNlAJ9/2GBSEKY1Up3nA+P30bEa2RsyYgCg0lTi
+y0hvgefy4h9rBX2f/GO8Sk=
=cp2Z
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list