BundleReader, Containers, and file IO

Robert Collins robertc at robertcollins.net
Thu Oct 25 07:31:40 BST 2007


On Thu, 2007-10-25 at 16:25 +1000, Andrew Bennetts wrote:
> 
> However, I'm not sure that for bundles we actually care about the
> requirement
> that we never over-read; as far as I can tell, that code is just used
> with real
> files that simply return '' when there are no more bytes available.
> In this
> case we don't need limit our reads to how much we are certain is safe
> to read,
> and can simply keep pulling in e.g. 16K chunks (or more if we know
> we're reading
> a large body).  The logic is simpler, and much faster.  The benchmarks
> are all
> better than bzr.dev, and the “big_tree” ones are *twice* as fast!  

Packs use containers too; it would be nice to see the impact this has.
Is there a branch I can pull, I'll happily run my performance tests to
see how it pans out...

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071025/4e326dc7/attachment.pgp 


More information about the bazaar mailing list