[MERGE] [PACKS] renaming of experimental to knitpack

Ian Clatworthy ian.clatworthy at internode.on.net
Thu Oct 25 06:03:39 BST 2007


Robert Collins wrote:
> On Thu, 2007-10-25 at 12:33 +1000, Ian Clatworthy wrote:
> 
> bb:resubmit

New version attached.

> When we discussed this on IRC I thought it would just be
> '--format=knitpack-experimental'.
> 
> I don't object to the larger change, but I don't see what it really buys
> us, and it has lost us some things: you haven't altered info to flag
> this as experimental in the UI, and not having experimental in the name
> means people won't know if they follow a blog post that its experimental
> at all, or ever, until we tell them *after* they hit a glitch.

Agreed. Fixed.

> 
>> +    help='New in 0.92: Pack-based format with data compatible with '
>> +        'dirstate-tags format repositories. Incompatible with bzr <
>> 0.92. '
>> +        'WARNING: This format is experimental so data in it may '
>> +        'not be upgradable to release formats of bzr.', 
> 
> 
> As far as I'm concerned, if we are encouraging people to play with this,
> we should give them the same guarantee about support - that is remove
> the warning about 'data may not be upgradeable'. Rather say something
> like 'This format is experimental - please read the documentation in
> <LINK TO THE PACK DOCO> before using.'

Done. As discussed on IRC, I've referred users to the existing
developers/knitpack.html doc on doc.bazaar-vcs.org on the assumption
that usage instructions will be included there by the time the release
date arrives. I'm planning to submit another patch with those
instructions RSN (unless you wish to do it).

> @@ -1721,8 +1721,8 @@
>              
>      def get_format_string(self):
>          """See RepositoryFormat.get_format_string()."""
> -        return "Bazaar Experimental subtrees\n"
> +        return "Bazaar knitpack subtrees\n"
>                           ^  I would capitalise this, and add 0.92 into
> the format string on disk. This makes for better errors in old clients.

Good points. The new on-disk strings are far more explanatory and
include the version # now.

Ian C.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pack-naming-2.patch
Type: text/x-patch
Size: 23055 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071025/ee462fae/attachment-0001.bin 


More information about the bazaar mailing list