[MERGE] Add test framework for checking code that raises python warnings

John Arbash Meinel john at arbash-meinel.com
Wed Oct 24 17:28:12 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> We have some support for checking that code raises a DeprecationWarning,
> but it's not useful for checking that it raises a Python warning, and we
> have some places where we do so.
> 
> Writing this does make me wonder if we should be just sending warnings
> to .bzr.log by default - if we're e.g. failing to release a lock in bzr
> there's not much point telling end users about it.

I think the LockWarning is for developers. We may want an env var that
developers can set, so that you can see things like this.

Anyway

BB:approve

I'm not sure that this patch actually provides a lot (since nobody is actually
using callCatchWarnings), but it does seem reasonable, and it has tests.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHH3KbJdeBCYSNAAMRAs8iAKDHgLTUxu9E45+unPJ+dMpcz7UolQCgw81P
HFFFX8EkpMx4sTwObIJbzAI=
=CC7I
-----END PGP SIGNATURE-----



More information about the bazaar mailing list