[MERGE] graph.heads() performance bugfix
John Arbash Meinel
john at arbash-meinel.com
Mon Oct 22 20:08:10 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
...
> As mentioned on IRC, one line not 2 here please.
>
>> + if key == 'deeper':
>> + import pdb;pdb.set_trace()
>> + self.fail('key deeper was accessed')
>
> Hmm. When the tests pass, this 'import pdb;...' will never happen but we
> don't want it there in production code I assume.
I would probably agree, as it means bots auto-running the test suite will get
hung. Even though I have found it to be very useful when manually testing.
Places like this tend to help, in that the author of the test thought it would
be a good place to figure out what is going on. (A likely point of failure, etc.)
So we *might* consider just commenting it out, rather than deleting it.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHHPUaJdeBCYSNAAMRApMvAKCkgg3oLQRAX4t1YgoVjnCFPoWpBQCfeDPC
MGNrpvJ8wSHqU2q/dkvKsrc=
=KzrN
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list