[MERGE] Register netloc protocols at 'register_transport_proto' time

John Arbash Meinel john at arbash-meinel.com
Fri Oct 19 20:59:35 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The attached patch fixes the bug I just mentioned about missing netloc protocol
registrations when sharing transports.

I went ahead and defaulted the parameter to False, because there were more
protocols that should not be registered. (All of the decorators, and memory, etc.)

Also, this fixes some unknown bugs, in that https+urllib and https+pycurl were
never registered.

Do we need a test for this? Perhaps just a test that if you set
register_netloc=True it adds it to urlparse's netloc list? And one that when it
isn't set, it doesn't?

Also, I need to add a NEWS entry, but I wanted to reference the bug that I just
submitted, but Malone doesn't seem to want to give me a bug number yet. (Which
is weird because I got a failure right away, but haven't gotten one for success.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHGQynJdeBCYSNAAMRAgG+AJ0Sd4Eux6/V/isQCb1Q991K9zjd8gCeNq4U
D4PhqWlMgvhWmJddUqglNf4=
=vskP
-----END PGP SIGNATURE-----



More information about the bazaar mailing list