[MERGE][bug #152360] Always set inv.root.revision

John Arbash Meinel john at arbash-meinel.com
Fri Oct 19 18:27:33 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

A long time ago, the format 5 inventory changed. It started adding a
revision_id to the the overall inventory. However, this means that there are 2
slightly different formats.
Bazaar <= 1677 uses the format without revision_id, >= 1678 uses the one with
revision_id.
The attached patch fixes:
https://bugs.launchpad.net/bzr/+bug/152360

by updating the serializer to properly handle both cases. We were already
passing the hint, we just weren't using it properly.

Arguably this could be tested at just the XML serializer level, but I wrote the
repository tests first (because I thought it needed to be fixed there.) I can
remove them, but usually if I've taken the time to write a test, I leave it in.

I think this is truly critical for 0.92, since it breaks the ability to read
older branches.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHGOkFJdeBCYSNAAMRAk5lAJ9noG4Nwy1a5//S3ZCQS1GNyqr+DwCdHv+M
ejo/A1Py12D1Z86YeE91OkY=
=4xsK
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: missing_root_revision_152360.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20071019/b5eb0d45/attachment.diff 


More information about the bazaar mailing list