[MERGE][bug 154259] Fix typo in ftp.py
John Arbash Meinel
john at arbash-meinel.com
Fri Oct 19 18:07:46 BST 2007
John Arbash Meinel has voted tweak.
Status is now: Approved
Comment:
+ def test__reconnect(self):
+ t = self.get_transport()
+ t.put_bytes('foo', 'test bytes\n')
+ self.assertEqual('test bytes\n', t.get_bytes('foo'))
+ t._reconnect()
+ t.put_bytes('foo', 'test bytes\n')
+ self.assertEqual('test bytes\n', t.get_bytes('foo'))
Wouldn't it make more sense to change what bytes are written? Just to
make sure the second put_bytes is actually putting data, rather than
just returning the original bytes?
Something like:
+ t.put_bytes('foo', 'test more bytes\n')
+ self.assertEqual('test more bytes\n', t.get_bytes('foo'))
For details, see:
http://bundlebuggy.aaronbentley.com/request/%3Cm2wstj8irq.fsf%40free.fr%3E
More information about the bazaar
mailing list