[MERGE] Packs. Kthxbye.

[Ian Clatworthy]

Robert Collins wrote:
> On Fri, 2007-10-19 at 12:53 +1000, Ian Clatworthy wrote:

>> BTW, NewPack subclasses Pack yet doesn't call the Pack constructor in
>> its own. That smells bad to me.
> 
> It calls the constructor, I think you are misreading.

I did sorry.

> I've put copious comments on this in the code. Using hashes to mean
> 'have same content' is not a feature IMNSHO. But race conditions with
> renames mean we need a complicated insertion process to do this without
> suffering hash collisions anyway. The current state is not sufficiently
> good IMO, but not particularly dangerous for now.

Thanks for the explanation.

Ian C.