[MERGE] Packs. Kthxbye.

Ian Clatworthy ian.clatworthy at internode.on.net
Fri Oct 19 03:58:29 BST 2007


Robert Collins wrote:
> On Fri, 2007-10-19 at 12:15 +1000, Ian Clatworthy wrote:
>> Robert Collins wrote:
>>
>>>> +    def _refresh_data(self):
>>>> +        if self._write_lock_count == 1 or self.control_files._lock_count==1:
>>>>
>>>> ^- Extra spaces around the '==
>> Looking at the diff from 2844 to 2847, I think John meant to add spaces
>> around the last ==, not remove them from the first.
> 
> PEP-8. 

Yep. It says ...

Always surround these binary operators with a single space on
      either side: assignment (=), augmented assignment (+=, -= etc.),
      comparisons (==, <, >, !=, <>, <=, >=, in, not in, is, is not),
      Booleans (and, or, not).

Ian C.



More information about the bazaar mailing list