[MERGE] Packs. Kthxbye.

Martin Pool mbp at sourcefrog.net
Thu Oct 18 09:26:24 BST 2007


trivial, or no comments:

>  bzr                                                                  |    1
>  bzrlib/tests/interrepository_implementations/test_interrepository.py |    2

done, or no comments:
>  bzrlib/knit.py                                                       |    3
>  bzrlib/bzrdir.py                                                     |   20
>  bzrlib/index.py                                                      |   11
>  bzrlib/reconcile.py                                                  |   35
>  bzrlib/repofmt/knitrepo.py                                           |   13
>  bzrlib/repository.py                                                 |  242 +
>  bzrlib/tests/repository_implementations/test_repository.py           |   43
>  bzrlib/tests/test_repository.py                                      |  599 +++

>  doc/developers/repository.txt                                        |   46

The braindump docs in here are fine as far as they go.  It would be
good to have some more format documentation; that doesn't need to
block the merge but we could try to capture it while it's still fresh
in your mind.

looks like just mechanical changes to use tuples not lists, or tighter locking:
>  bzrlib/tests/repository_implementations/__init__.py                  |  180 -
>  bzrlib/tests/repository_implementations/helpers.py                   |   24
>  bzrlib/tests/repository_implementations/test_check.py                |   10
>  bzrlib/tests/repository_implementations/test_check_reconcile.py      |    4
>  bzrlib/tests/repository_implementations/test_commit_builder.py       |   14
>  bzrlib/tests/repository_implementations/test_fileid_involved.py      |   13


>  18 files changed, 2783 insertions(+), 186 deletions(-)

good effort ;-)

Several methods have changed from returning lists to returning tuples,
as you mentioned the other day, but their docstrings are not updated.

We need some notes in NEWS describing the new format and saying how to
upgrade it and any caveats, including the bug numbers for things that
aren't implemented yet.  This can come later.

I'm still working through the guts of it in packrepo, will post a
commented diff when that's done.



More information about the bazaar mailing list