[MERGE] Factor out the Graph.heads() cache from _RevisionTextVersionCache for reuse, and use it in commit.

John Arbash Meinel john at arbash-meinel.com
Thu Oct 18 03:51:27 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
...

> 
> Some code modifies the return value deliberately.
> 
> -Rob
> 

I would argue that you let them create their own sets. Rather than forcibly
creating a new object every time you enter this function.

If *all* callers need to modify the set, then fine. But I doubt that is the case.

Maybe it is an API break... but probably a rather minor one at that.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHFsovJdeBCYSNAAMRAtbOAJ9kwYtijzhuXD4J3lbFkvhq0UGnGgCgutvz
HQJDup5P1FnLRYatuzT+rLM=
=J6OA
-----END PGP SIGNATURE-----



More information about the bazaar mailing list