Rev 2912: Fix bug #149113 so that executable is properly set on win32. in http://bzr.arbash-meinel.com/branches/bzr/0.92-dev/dirstate_error_149113

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Tue, 2007-10-16 at 16:24 -0500, John Arbash Meinel wrote:
>> At http://bzr.arbash-meinel.com/branches/bzr/0.92-dev/dirstate_error_149113
>>
>> ------------------------------------------------------------
>> revno: 2912
>> revision-id: john at arbash-meinel.com-20071016211734-u0ce8cr11khccb65
>> parent: pqm at pqm.ubuntu.com-20071016112750-1q8brfaq6metpfn8
>> committer: John Arbash Meinel <john at arbash-meinel.com>
>> branch nick: dirstate_error_149113
>> timestamp: Tue 2007-10-16 16:17:34 -0500
>> message:
>>   Fix bug #149113 so that executable is properly set on win32.
>>   The new path_content_summary() returns None when a platform
>>   does not support the executable bit, asking the caller to
>>   decide a policy.
>>   This patch changes CommitBuilder.record_entry_contents()
>>   so that it sets a policy of using the parent's value,
>>   unless there are no parents, in which case it uses None.
>
> I think a better fix would be to have the win32 working tree provide a
> value inp path_content_summary, rather than the commit builder which is
> repository centric.
>
> -Rob

That is what I thought, too, but you had an explicit comment:
            if not supports_executable():
                executable = None # caller can decide policy.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHFS5fJdeBCYSNAAMRAsJyAJ9RYumaFYhQHRpX2RLyjbl5vitGnQCeKQCd
cPMfihS5TnqKXyztoQJN6NI=
=WwZV
-----END PGP SIGNATURE-----