[MERGE]Change "print >> outfile" to "outfile.write".

John Arbash Meinel john at arbash-meinel.com
Tue Oct 16 20:05:21 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Blake Winton wrote:
...

>> I would certainly change this:
>> +    sys.stderr.write("  (need %d.%d or later)" % NEED_VERS)
>> to sys.stderr.write("  (need %d.%d or later)\n" % (NEED_VERS,))
> 
> Well, I don't think that would be the right thing there, because
> there are two "%d"s in the format string, and so I'm guessing that
> NEED_VERS contains two items, and doing the safe would break it.
> 
> (The last two lines should probably change from:
> +    sys.stderr.write("  (need %d.%d or later)" % NEED_VERS)
> +    sys.stderr.write('\n')
> to:
> +    sys.stderr.write("  (need %d.%d or later)\n" % NEED_VERS)
> but I think I might leave the merger to do that at their discretion.)

Yeah, I was just focusing on moving the '\n' rather than adding an extra call.
I didn't pay enough attention to the rest, and just noticed it because as I was
typing it I put in the extra tuple by nature.

Anyway,

BB:approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHFQtxJdeBCYSNAAMRAtj4AKDX5W1t853sekUaHCkdtK38KULdOgCfbYmL
eCql52Caiq+qBCvzdvZNBtU=
=4ZpS
-----END PGP SIGNATURE-----



More information about the bazaar mailing list