[QBZR][Merge] Add unidiff format to diff dialog

Goffredo Baroncelli kreijack at tiscalinet.it
Tue Oct 16 18:27:28 BST 2007


On Tuesday 16 October 2007, you (Alexander Belchenko) wrote:
> Goffredo Baroncelli пишет:
[...]
> It's looks better but I disagree with this changes:
> 
> @@ -272,7 +286,7 @@
>               self.append(diff)
> 
>           for path, file_id, kind in delta.added:
> -            diff = FileDiff(_('added'), path)
> +            diff = FileDiff('added', path)
[...] 
> 
> Don't revert my i18n stuff, please.
> 

In my patch you can see also

@@ -363,12 +377,12 @@
             html1.append('<div style="%s">%s</div>' % (STYLES['title'], 
diff.path))
             html1.append(self._get_metainfo_template() % (STYLES['metainfo'],
                                                           diff.old_date,
-                                                          diff.status,
+                                                          _(diff.status),

So I can do some decision on the basis of the .status value. 
In any case the .status values will be translated before the output phase.

Sorry if I didn't explain this fact enough.

P.S.
I can't reply directly to your email <bialix_AT_ukr.net>...


-- 
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack at inwind.it>
Key fingerprint = CE3C 7E01 6782 30A3 5B87  87C0 BB86 505C 6B2A CFF9



More information about the bazaar mailing list