Problems with bzr.dev tonight

Robert Collins robertc at robertcollins.net
Tue Oct 16 01:15:10 BST 2007


On Mon, 2007-10-15 at 23:22 +1000, Martin Pool wrote:
> 
> That seems to be the problem - the data returned by _data.read_records
> doesn't have
> annotations before the lines - when we later try to split them out, we
> die on any records that don't have a space.
> 
> Worse, if every changed line does have a space, this will silently get
> things 
> wrong.  We should possibly add an assertion that there is actually a
> space.

So, I think there are two issues here.

a) There is bad data being exported by Ian's patch to convert
unannotated knits to annotated ones on the fly.
b) The delta application code/deserialisation code isn't detecting this
explicitly, so you don't really get the chance to tell whats going on.

For a), we'll need to identify and repair all revisions I've created
recently I suspect; it may be that only merges cause this - identifying
the bug will be a key part of being able to tell whats corrupt and whats
not. We also, obviously, need to fix the bug so that I can, from packs,
emit data readable by knits properly.

For b), as long as we profile it to avoid performance headaches (delta
application/deserialisation is critical path), we're good to add checks.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071016/5be75043/attachment.pgp 


More information about the bazaar mailing list