[QBZR][MERGE] Add unidiff format to diff dialog
Lukáš Lalinský
lalinsky at gmail.com
Mon Oct 8 20:30:57 BST 2007
On 10/8/07, Goffredo Baroncelli <kreijack at tiscalinet.it> wrote:
> Hi all,
>
> the enclosed bundle adds the unidiff format to the qbzr diff dialog.
> The patch was updated on the basis of the suggestions received:
> - the switch between the format is done via radio-box control
> - the new code doesn't calculates the diff twice
> - the code uses to the function _()
>
> Please, Lukáš review it and if you like merge it. Otherewise free feel to send
> comments.
This looks great, thanks. Although I still have one technical comment
- please use QStackedWidget instead of
setVisible(True)/setVisible(False) for swapping the diff views. It
should be a little bit faster that way, but mainly it would produce
less flickering.
Lukas
More information about the bazaar
mailing list