[MERGE] Fix bug 146715: bzr+ssh:// and sftp:// transports should not assume port-not-specified means port 22
Martin Pool
mbp at canonical.com
Mon Oct 8 04:08:20 BST 2007
Martin Pool has voted comment.
Status is now: Semi-approved
Comment:
+class SSHPortTestMixin(object):
(comment) It bothers me that we have both mixin and scenario
tests, though for your particular case using this is simpler.
It seems strange to me that ssh and sftp need to be treated differently
in this regard. It's true that they are the places where the
unspecified port is most likely to be different to the protocol standard
port. But why not in every case just keep unspecified as None and let
the transport handle this?
Thanks for working on this though.
For details, see:
http://bundlebuggy.aaronbentley.com/request/%3C20071008023033.GA9363%40steerpike.home.puzzling.org%3E
More information about the bazaar
mailing list