[QBZR] Add the "simple" diff to diff dialog

Goffredo Baroncelli kreijack at tiscalinet.it
Fri Oct 5 20:17:26 BST 2007


Hi Lukáš,

On Friday 05 October 2007, Lukáš Lalinský wrote:
> On 10/5/07, Goffredo Baroncelli <kreijack at tiscalinet.it> wrote:
> > Hi all
> >
> > The enclose bundle adds two feature to qbzr
> > 1) the diff dialog shows both the "side-by-side" diff and the classic diff
> > output. The switch between the modes is done using a tab at the top.
> 
> I'm not sure about this for two reasons:
>  - It calculates the diff twice -- unified diff could be easily
> produced from the TreeDiff class. Doing this all in Python is slow
> enough, not need to make it even slower.

Yes, I agree that my patch can be optimized. But I want a feedback quickly :-)

>  - I was kind of reserving tabs for multiple files, so I could have
> full-file diffs with each file on it's own tab. I'd probably prefer
> some kind of button to switch the view, or maybe radio buttons:
> 
>  (o) Side by side diff  ( ) Unified diff

The enclosed bundle implement this. 

> 
> > 2) in the commit dialog, the user can selects multiple file and see the 
files
> > diff (or revert it)
> 
> I like this one, will cherry-pick. :)

Good

> > Lukáš, if you like, please apply.
> >
> > Goffredo
> 
> Lukas
> 



-- 
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack at inwind.it>
Key fingerprint = CE3C 7E01 6782 30A3 5B87  87C0 BB86 505C 6B2A CFF9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: img.png
Type: image/png
Size: 39537 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071005/f41b9b7b/attachment-0001.png 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff.bundle.patch
Type: text/x-diff
Size: 10605 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071005/f41b9b7b/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071005/f41b9b7b/attachment-0001.pgp 


More information about the bazaar mailing list