[QBZR] Add the "simple" diff to diff dialog

Lukáš Lalinský lalinsky at gmail.com
Fri Oct 5 14:39:04 BST 2007


On 10/5/07, Goffredo Baroncelli <kreijack at tiscalinet.it> wrote:
> Hi all
>
> The enclose bundle adds two feature to qbzr
> 1) the diff dialog shows both the "side-by-side" diff and the classic diff
> output. The switch between the modes is done using a tab at the top.

I'm not sure about this for two reasons:
 - It calculates the diff twice -- unified diff could be easily
produced from the TreeDiff class. Doing this all in Python is slow
enough, not need to make it even slower.
 - I was kind of reserving tabs for multiple files, so I could have
full-file diffs with each file on it's own tab. I'd probably prefer
some kind of button to switch the view, or maybe radio buttons:

 (o) Side by side diff  ( ) Unified diff

> 2) in the commit dialog, the user can selects multiple file and see the files
> diff (or revert it)

I like this one, will cherry-pick. :)

> Lukáš, if you like, please apply.
>
> Goffredo

Lukas



More information about the bazaar mailing list