[MERGE] (robertc) Use prejoined content for knit storage when performing a full-text store of unannotated content. (Robert Collins)

Aaron Bentley aaron.bentley at utoronto.ca
Fri Oct 5 03:04:56 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> This is a little ugly, but I can't see right now how to clean it up, so
> submitting for review - if you can suggest a better structure for making
> it hang together that does not involve a full overhaul of the knitdata|
> content|factory relationships at this point, please suggest it!

bb:comment

Well, it seems like you could pass line_bytes into
factory.lower_fulltext, and simply ignore it in
KnitAnnotateFactory.lower_fulltext.

Or am I missing something?

> +    def _record_to_data(self, version_id, digest, lines, dense_lines=None):
>          """Convert version_id, digest, lines into a raw data block.
>          
> +        :param dense_lines: The bytes of lines but in a denser form.

^^^ This description doesn't help me understand what a "denser form" may be.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHBZvI0F+nu1YWqI0RAkxSAKCElGNdhhbE66TGVfxyWrPHrlgxbwCfdRUs
vE0J4xvuyHuIXu20v8hU8jA=
=pd9o
-----END PGP SIGNATURE-----



More information about the bazaar mailing list