[MERGE] skip windows-unfriendly tests
Marius Kruger
amanic at gmail.com
Thu Oct 4 09:58:45 BST 2007
On 10/4/07, Alexander Belchenko <bialix at ukr.net> wrote:
>
> Martin Pool пишет:
> > Status is now: Conditionally approved
> > Comment:
> > In the case of test_remove_changed_files_from_child_dir - I don't see
> > why we're trying to remove . - it seems a bit unnecessary. It might be
> > better to remove '.' from the removed file list and see if that passes
> > on Windows, unless anyone can see why we really want to keep it.
>
> I don't understand why '.' should be deleted in test, but Marius said
> it's important for this test. Without rm '.' test should pass.
>
I just made a comment:
I think we should rather split out the '.' case, than just remove it.
> Since it is something a user might do,
> we should have a test for it.
>
> Is the current behaviour on windows acceptable for this or is it giving a
> nasty traceback?
> Should the method be modified to give a nice error message/warning?
I'm not against merging,
but I do think it will be good to have a test for
something a user might try (for whatever reason).
We might decide not to support it, and thus test if the proper error message
will be given.
This is a minor issue and can definitely be addressed in another patch
(which I can make if you want).
regards
marius
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20071004/2bbe235f/attachment.htm
More information about the bazaar
mailing list