[MERGE][Bug 140432] Connection sharing for bound branches
Martin Pool
mbp at canonical.com
Thu Oct 4 07:04:24 BST 2007
Martin Pool has voted tweak.
Status is now: Conditionally approved
Comment:
+ def test_commit_mine_modified(self):
+
+ self.start_logging_connections()
+
+ commit = builtins.cmd_commit()
+ # commit do not provide a directory parameter, we have to
change dir
+ # manually
+ os.chdir('local')
+ commit.run(message=u'empty commit', unchanged=True)
+ self.assertEquals(1, len(self.connections))
Why aren't you just using run_bzr in these tests? I guess there's a
good reason but I think you should say so in a comment. That does take
a directory option.
Can someone tell me what the difference is meant to be between
tests/blackbox and tests/commands? The commands docstring is unhelpful
and actually seems wrong:
"""Commands behaviour tests for bzr.
This tests the behaviour of the commands.
The API is tested in the tests/blackbox files.
"""
The blackbox tests are meant to test commands, not apis.
Aside from that the patch looks fine.
For details, see:
http://bundlebuggy.aaronbentley.com/request/%3Cm24phkujs6.fsf%40free.fr%3E
More information about the bazaar
mailing list