[MERGE] skip windows-unfriendly tests
Alexander Belchenko
bialix at ukr.net
Thu Oct 4 07:00:06 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool пишет:
> Martin Pool has voted tweak.
> Status is now: Conditionally approved
> Comment:
> In the case of test_remove_changed_files_from_child_dir - I don't see
> why we're trying to remove . - it seems a bit unnecessary. It might be
> better to remove '.' from the removed file list and see if that passes
> on Windows, unless anyone can see why we really want to keep it.
I don't understand why '.' should be deleted in test, but Marius said
it's important for this test. Without rm '.' test should pass.
> With test_location_list I guess the problem is that on Windows the paths
> come back with backslashes or drive letters? Could we just have the
> platform test cause it to compare to different values? Or is the test
> not going to work at all?
Drive letter is the problem. And drive letter could be different, I cannot
hardwire C: in this test. I try to construct paths in run-time, but
it turns test to unreadable mess. I can create copy of this test specially
for windows case if you want, to improve clarity of testing.
> [update]: happy to have this merged if you do those things, or help me
> realize why they're not needed.
Is my comment shed some light?
- --
[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHBIFmzYr338mxwCURAv+uAJsFNeMf78IaXb9mpBnXH076XNRfEwCeIU+y
I614/UKr0TO09fpRsVqZAp8=
=kNL+
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list