[BUG] Different results when passing 'parent_texts'

John Arbash Meinel john at arbash-meinel.com
Fri Sep 28 17:51:43 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> I'm getting a really weird result when trying to do a conversion.
> 

I'm really surprised nobody responded to this. Maybe I was too verbose.

In short, we have a bug with the returned value from Knit.add_lines(). The
content it returns has had its last line munged (to always contain a newline).
It doesn't effect the *correctness* of the diff, but it does mean that if you
have a file without a final newline, every revision will show up as that line
being changed. (Unless in memory you are caching the text and passing it back in.)

Because it isn't a correctness issue, I don't feel like taking the time to work
on it. But it does seem like a bit of an issue. (Especially since at the
moment, the next format uses the same code.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG/TEeJdeBCYSNAAMRAvl7AKDVApCyqlnJbUZtWVvKnwQqN7+JkgCdHUZo
1mw/7E4e23EJlqjjw2itxJE=
=AKBr
-----END PGP SIGNATURE-----



More information about the bazaar mailing list