Friendlier bzr+ssh errors for Launchpad

[Andrew Bennetts]

John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> I just tried to push to the wrong location and I got this:
> % bzr push bzr+ssh://bazaar.launchpad.net/~bzr/bzr-cvsps-importer/trunk
> bzr: ERROR: Generic bzr smart protocol error: <Fault 8002: 'error'>
> 
> versus
> 
> % bzr push sftp://bazaar.launchpad.net/~bzr/bzr-cvsps-importer/trunk
> bzr: ERROR: Permission denied: "/~bzr/bzr-cvsps-importer/trunk": [Errno 13]
> Directories directly under a user directory must be named after a project name
> registered in Launchpad <https://launchpad.net/>.
> 
> Fault 8002: doesn't really help figure out what I did wrong, but the sftp error
> message does.
> 
> I know there was quite a bit of work done for the sftp server to report nice
> error messages. It would be nice if that could carry over to bzr+ssh.

This is almost certainly the fault of Launchpad, not the bzr+ssh code in Bazaar.
“Fault 8002” is probably an XML-RPC error on the server-side that isn't getting
caught and reported properly by bazaar.launchpad.net code.

 affects launchpad-bazaar

-Andrew.