[MERGE] (robertc) Knit repo format tidyups from the packs branch. (Robert Collins)

[Robert Collins]

On Wed, 2007-09-26 at 12:01 +1000, Ian Clatworthy wrote:
> Robert Collins wrote:
> > Some minor tidyups in the knit repo format - reduce code duplication,
> > add a couple of lazy imports, and some -Devil printing.
> 
> At least one tweak required I think.
> 
> bb: comment
> 
> I don't know enough to confirm that one change is acceptable or
> otherwise. If Martin (say) indicates that it's ok, consider this a tweak
> vote.
> 
> 
> 
> >          mutter('creating repository in %s.', a_bzrdir.transport.base)
> > -        dirs = ['revision-store', 'knits']
> > +        dirs = ['knits']
> 
> So RepositoryFormatKnit.initialize will no longer create a
> revision-store directory. Is this no longer required? Is it done
> elsewhere now? This is the change I can't approve because I don't know
> enough about whether it is safe or not.

Its a bug fix. Weave based repositories used a revision-store, knits
never have.

> > +    repository_class = KnitRepository
> > +
> 
> You've added this change to RepositoryFormatKnit1 when I think it ought
> to go higher in the inheritance hierarchy, namely in
> RepositoryFormatKnit. I say that because RepositoryFormatKnit.open has
> been changed to use that attribute now (instead of the hard-coded
> KnitRepository) so it ought to exist there.

RepositoryFormatKnit is now an abstract base class, so no, it should not
be present at that level, only in concrete classes.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070927/34c624f2/attachment-0001.pgp