[MERGE] skip windows-unfriendly tests

Alexander Belchenko bialix at ukr.net
Tue Sep 25 19:49:28 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marius Kruger пишет:
> hi,
> 
> On 9/25/07, Martin Pool <mbp at canonical.com> wrote:
>> Martin Pool has voted comment.
>> Status is now: Semi-approved
>> Comment:
>> In the case of test_remove_changed_files_from_child_dir - I don't see
>> why we're trying to remove . - it seems a bit unnecessary.  It might be
>> better to remove '.' from the removed file list and see if that passes
>> on Windows, unless anyone can see why we really want to keep it.
>>
> 
> I think we should rather split out the '.' case, than just remove it.
> Since it is something a user might do,
> we should have a test for it.
> 
> Is the current behaviour on windows acceptable for this or is it giving a
> nasty traceback?
> Should the method be modified to give a nice error message/warning?

On Windows you cannot remove current directory, because you get PermissionDenied error:

C:\Temp\2\a>py24 C:\work\Bazaar\mydev\bzr.dev\bzr rm .
bzr: ERROR: [Errno 13] Permission denied: u'C:/Temp/2/a'

- --
[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG+Vg3zYr338mxwCURAuBcAJ4/OmiA0NEjj1j6KPaKI2+0XVplWQCcDusX
Qnm7S7ZMUqMWr+FvDjRM7Eg=
=+50l
-----END PGP SIGNATURE-----



More information about the bazaar mailing list