[MERGE] fixes for TestCase.run_bzr* methods

Alexander Belchenko bialix at ukr.net
Tue Sep 25 08:40:30 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool пишет:
> On 9/25/07, Alexander Belchenko <bialix at ukr.net> wrote:
> 
>> This fix try to resolve problem that does not exists on Linux.
>> I suppose that command line for some test auto-constructed based on
>> output of some osutils or winutils functions. Almost all of them return
>> unicode objects for paths or filenames (if sys.platform == 'win32').
>> IMO it's the case.
> 
> Would the fix John suggests be ok for you?  I think it has less impact
> on other parts of the test suite.
> 
> if isinstance(args, unicode):
>  args = [a.decode('utf8') for a in shlex.split(args.encode('utf8'))]

My original change is also quite trivial and I believe is faster
than encode/decode/list comprehension. I have no objection for this
variant though.

[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG+LtuzYr338mxwCURAsm2AJ9l4vdrNCw2SReDAyU8PRGBPdgftgCeLFPJ
VG2EvqBdTGRLJ7rqJQrOxw0=
=5nO6
-----END PGP SIGNATURE-----



More information about the bazaar mailing list