[BUG] bzr.dev fails when 'rollover_trace_maybe'

Alexander Belchenko bialix at ukr.net
Mon Sep 24 06:16:17 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel пишет:
> I just got this error:
> % bzr --no-plugins st
>     Traceback (most recent call last):
>   File "/home/jameinel/bin/bzr", line 98, in <module>
>     bzrlib.trace.enable_default_logging()
>   File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/trace.py", line 218, in
> enable_default_logging
>     open_tracefile()
>   File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/trace.py", line 177, in
> open_tracefile
>     _rollover_trace_maybe(_bzr_log_filename)
>   File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/trace.py", line 154, in
> _rollover_trace_maybe
>     rename(trace_fname, old_fname)
> NameError: global name 'rename' is not defined
> 
> I think one of the recent changes removed 'rename' from the local
> namespace, so now it is failing to backup the old .bzr.log to .bzr.log.old.
> 
> I don't know what patch caused it


bzr log -r2845

I think Martin want to use lazy_import, and therefore fix should be:

- -     rename(trace_fname, old_fname)
+     osutils.rename(trace_fname, old_fname)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG90ghzYr338mxwCURAppDAKCK6ZOjG5H8ejXstIJ7x8EAcgB+UgCePDKf
6NqOphjdqBN9C3kW8caISSM=
=LDhn
-----END PGP SIGNATURE-----



More information about the bazaar mailing list