[MERGE] Be more efficient with sha operations during commit

[Robert Collins]

On Mon, 2007-09-24 at 13:53 +1000, Ian Clatworthy wrote:
> Robert Collins wrote:
> > This saves 10 seconds or so on an initial commit of a mozilla tree by
> > using sha_string, rather than sha_strings.
> 
> bb:tweak
> 
> > As part of it I've removed an unused function from the _KnitData class,
> 
> As _KnitData is a private class, it's not strictly needed though
> mentioning in NEWS that add_record was removed would be nice.

As it really is internal,  I think its noise to do that.


> Setting of size & bytes is common to both branches of the if statement
> so pull it out as common code.

I have another patch that is not yet baked that makes the assignment be
different in one branch, for another performance win.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070924/a11cc499/attachment.pgp