[MERGE] Progress on passing the full test suite on OSX

Martin Pool mbp at canonical.com
Fri Sep 21 06:58:30 BST 2007

Martin Pool has voted tweak.
Status is now: Conditionally approved
Thanks for doing this, getting at least everything to a diagnosed xfail 
would be a good step forward.

+    def assertIsSameRealPath(self, path1, path2):
+        """Fail if path1 and path2 points to different files"""
+        self.assertEqual(bzrlib.osutils.realpath(path1),
+                         bzrlib.osutils.realpath(path2))

(comment) Maybe this should give more of a message if they fail, with 
both the apparent and real paths?  Maybe it'll be obvious.

          if sys.platform == 'darwin':
+            from bzrlib.workingtree import WorkingTree3
+            if type(self.tree1) is WorkingTree3:
+                self.knownFailure("Mac OSX doesn't preserve unicode"
+                                  " combining characters"
+                                  " and WorkingTree3 failed to detect"
+                                  " removed files")

Can you include a bug number for this please, if there is one?

      def test__remote_path(self):
+        if sys.platform == 'darwin':
+            self.knownFailure('Mac OSX symlinks /tmp to /private/tmp,'
+                              ' testing against self.test_dir'
+                              ' is not appropriate')

I understand that it does this linking, but I don't understand why it's 
not appropriate.

For details, see: 

More information about the bazaar mailing list