[MERGE] code cleanups for bzrdir.py

Robert Collins robertc at robertcollins.net
Tue Sep 18 23:57:24 BST 2007


On Tue, 2007-09-18 at 17:20 +1000, Ian Clatworthy wrote:
> More minor code cleanups I'd like to see, this time in bzrdir.py. Once
> again, these are mostly comment fixes. There are a few code ones as
> well, namely:
> 
> * BzrDir.create was creating a transport then not using it
>   - poolie suggest the fix
> 
> * retire_bzrdir() would silently fail after 10,000 times :-)
> 
> * some dead/future code related to redirection has been commented
>   out because the results were never used
>   - this was recommended by vila on IRC.

I am allergic to commented out committed code.

Either its needed, deprecated, or deleted. We have a VCS for getting
back to old versions.


-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070919/056b0c49/attachment.pgp 


More information about the bazaar mailing list