[MERGE] Various test fixes and tweaks for packs.

[Jelmer Vernooij]

On Tue, 2007-09-18 at 06:58 +1000, Robert Collins wrote:
> On Mon, 2007-09-17 at 16:40 +0200, Jelmer Vernooij wrote:
> > Am Freitag, den 14.09.2007, 12:27 +1000 schrieb Robert Collins:
> > > === modified file
> > > 'bzrlib/tests/repository_implementations/test_repository.py'
> > > ---
> > > bzrlib/tests/repository_implementations/test_repository.py  2007-08-21
> > > 03:40:50 +0000
> > > +++
> > > bzrlib/tests/repository_implementations/test_repository.py  2007-09-14
> > > 02:19:41 +0000
> > > @@ -234,13 +234,6 @@
> > >          new_signature = wt.branch.repository.get_signature_text('A')
> > >          self.assertEqual(old_signature, new_signature)
> > >  
> > > -    def test_exposed_versioned_files_are_marked_dirty(self):
> > > -        repo = self.make_repository('.')
> > > -        repo.lock_write()
> > > -        inv = repo.get_inventory_weave()
> > > -        repo.unlock()
> > > -        self.assertRaises(errors.OutSideTransaction, inv.add_lines,
> > > 'foo', [], [])
> > > -
> > ^^^ I'd rather see this test not be removed because it is still valid
> > for non-pack formats. Perhaps change the assertRaises to check for
> > (errors.OutSideTransaction, errors.NotWriteLocked) ?
[...]

Thanks for explaining.

> I can make the test optional based on a repository attribute if you
> like, or reinstate it as a non-interface test for weaves and knits.
I'd prefer it as a non-interface test - I'd rather have information like
this just in the testsuite so it doesn't clutter up the
bzrlib.repository code.

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070918/08d192b8/attachment.pgp