[MERGE] New reconfigure command

[Ian Clatworthy]

Aaron Bentley wrote:

> I think this should address all your comments.  I have added scads of
> docstrings despite philosophical objections that it violates DRY, so
> that it can get merged separately from the discussion of how much
> documentation is appropriate.

Sure. Thanks.

> I have made all these variables private, so that only _plan_changes can
> set them.  It knows not to set create_branch without destroy_reference.

Thanks.

>> In particular, the doc needs to be clearer on:
>>
>> 1. What the default target_type will be if none is given on the command
>>    line.
> 
> It now errors.

Thanks. There is still the theoretical possibility of the API being
called with target_type set to an unhandled value so I think there is
(still) value in a terminating else, but it's your call.

bb:tweak

Two minor doc changes are needed as explained below. Also the
TestReconcile -> TestReconfigure typo mentioned by Daniel.

I've reviewed all the tests now and they look really good btw.

> === modified file 'NEWS'
> --- NEWS	2007-09-12 21:27:42 +0000
> +++ NEWS	2007-09-13 01:57:00 +0000
> @@ -11,6 +11,8 @@
>  
>    FEATURES:
>  
> +  * New ``reconfigure`` command (Aaron Bentley)
> +

This line needs to be indented one character to line up with all the
other bullets.

> +class cmd_reconfigure(Command):
> +    """Reconfigure the type of a bzr directory.
> +
> +    A target configuration must be specified.
> +
> +    For checkouts, the bind-to location will be auto-detected if not specified.
> +    The order of preference is
> +    1. For a lightweight checkout, the current bound location.
> +    2. For branches that used to be checkouts, the previously-bound location.
> +    3. The push location.
> +    4. The parent location.
> +    If none of these is available, --bind-to must be specified.
> +    """

The numbered list needs blank lines above and below for correct
formatting in the User Reference.

Ian C.