[MERGE] New reconfigure command

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> Aaron Bentley wrote:
>> This patch implements a "reconfigure" command.  It can convert from

> I haven't reviewed all the tests yet and I need more time to think about
>  some other bits a bit more. Even so, I hope there's enough feedback
> below to be helpful.

I think this should address all your comments.  I have added scads of
docstrings despite philosophical objections that it violates DRY, so
that it can get merged separately from the discussion of how much
documentation is appropriate.

>> +    def planned_changes(self):
>> +        """Return True if changes are planned, False otherwise"""
> 
> I'd prefer the name changes_are_needed() to stress the boolean nature.

I don't like "needed".  The changes are only "needed" in order to
satisfy the demands of the to_* method, but this method is independent
of those methods.

I like "planned".  So I renamed it to "changes_planned", which I think
gives a better hint that this is boolean.  I then renamed
"select_changes" to "_plan_changes", to emphasize the correlation.

> "planned_changes()" sounds like it ought to return the set of planned
> changes. Suggest making this method private as well (though don't mind
> if you think otherwise given it's parameterless).

I think that it makes sense for this to be a public method, and I can't
imagine the signature changing, so I left it public.

> Practically this might always be safe? Technically, if create_branch is
> True and destroy_reference isn't, *reference_info won't be set will it?

I have made all these variables private, so that only _plan_changes can
set them.  It knows not to set create_branch without destroy_reference.
> In particular, the doc needs to be clearer on:
> 
> 1. What the default target_type will be if none is given on the command
>    line.

It now errors.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG6qIW0F+nu1YWqI0RAv8TAJ432DKDKYgjA48/pgzLquaHEzTxVACZATMn
/33lIKNcRrdB4mb3EFvkijQ=
=F3+9
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reconfigure-2.patch
Type: text/x-patch
Size: 44662 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070914/2f0a5ead/attachment-0001.bin