[MERGE][0.91] Make RemoteRepository.sprout cope gracefully with servers that don't support the 'Repository.tarball' request.

[Martin Pool]

Martin Pool has voted tweak.
Status is now: Conditionally approved
Comment:
+    """Mock of a RemoteRepository's '_real_repository' attribute.
+
+    Used by TestRepositoryTarball.test_backwards_compatibility.
+    """

You could add:

   This intercepts the case where the RemoteRepository decides to fall 
back to sprouting the repository by using vfs operations.

I suppose it's obvious, it's just that with such a name I might have 
expected it to be more general.


-            raise errors.SmartServerError(error_code=response)
+        if (response == ('error', "Generic bzr smart protocol error: "
+                "bad request 'Repository.tarball'") or
+              response == ('error', "Generic bzr smart protocol error: 
"
+                "bad request u'Repository.tarball'")):

the indenting seems a bit strange, the second 'response' should be under 
the first.

The fix should be mentioned in news.


For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C20070914031103.GA32195%40steerpike.home.puzzling.org%3E