commit/commit-builder/inventory serialisation api friction

[Robert Collins]

On Fri, 2007-09-14 at 11:44 +1000, Ian Clatworthy wrote:
> Robert Collins wrote:


> > This might save a reasonably good amount of friction, but it would
> > couple the iteration order to the inventory serialisation logic, and
> > maybe thats a nuisance for some inventory types (though those could of
> > course buffer the entries as needed - 'finish_inventory' would still
> > exist in the api.
> 
> I don't think CommitBuilder should dictate to callers the order in which
> things must be passed. It's perfectly fine for it to be fastest in a
> given order but it needs to be robust enough to support an alternative
> one. In practice, that probably translates to:
> 
> 1. record_entry_contents can buffer serialised entries
> 2. finish_inventory should sort just to be sure.

Sorting requires the full path; we might be able to do something with a
decorated lines list at some point. Its down to about 0.4 of a second
now, so the wins there are capped quite low.

> As you might recall, I was proposing in an earlier patch that
> finish_inventory took an inventory delta. I still suspect that will give
> us the most flexibility longer term.

When inventories are based in small bits sure, but not today, and given
the file graph logic, possibly not ever.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070914/8fea996e/attachment.pgp