[MERGE][bug 128076][bug 131396][0.91] Reuse bound branch transport to avoid multiple connections

Martin Pool mbp at canonical.com
Tue Sep 11 01:11:24 BST 2007

Martin Pool has voted tweak.
Status is now: Conditionally approved

+        self.install_hooks()
+        update = builtins.cmd_update()
+        update.run()
+        self.assertEquals(1, len(self.connections))

It's nice that we can actually test this connects only once.  It would 
good to add some text to HACKING describing how people can use
TestCaseWithConnectionHookedTransport to test this kind of thing.
Also in that class it would have been better to call it something like
start_logging_connections(), rather than the more general 

-    def get_master_branch(self):
+    def get_master_branch(self, possible_transport=None):

(tweak) Why singular 'possible_transport' not plural?  I guess it's just 
a typo?

Aside from that looks good for 0.91.

For details, see: 

More information about the bazaar mailing list