[MERGE] Document code layout stuff

Kent Gibson warthog618 at gmail.com
Wed Sep 5 14:43:50 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Martin Pool wrote:
> This changes the developer guide to be more specific about how
> things should be spaced/indented.
>
> There have been a few cases where reviewers have said "please do X"
>  when pep8 doesn't (or doesn't clearly) require X.  abentley,
> lifeless and spiv said on irc that they agree with these rules (if
>  I've captured them accurately).
>
Hi Martin,

You've missed the one that usually catches me - that there should
always be space between function parameters.  PEP-8 doesn't explicitly
say there should be, though its examples all follow that rule.

e.g.

def __init__(self, width, height)

not

def __init__(self,width,height)



I'd like to see that one added to HACKING as well.

Cheers,
Kent.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG3rKVgoxTFTi1P8QRAq/1AKDAnFY33b0oi4F1v3xrmrYvdIozCQCfXK8y
f9TKzBtR1TWu+xiqj6dEfSU=
=SX6q
-----END PGP SIGNATURE-----



More information about the bazaar mailing list