[MERGE] updated deprecated of find_previous_heads

Aaron Bentley aaron.bentley at utoronto.ca
Tue Sep 4 13:49:04 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> I have:
>  - removed the kind special casing so that we can correctly use the
> revision level graph.

That is fine.  It's just another argument for multi-parent diffs ;-)

>  - fixed upgrade to use the new api (I missed this before)
>  - added hopefully comprehensive tests for the last modified revision
> value and the per-file graph creation.

> Aaron bentley wrote:
>> Given that you're introducing a new public method, it would be nice to
>> > test it.

> I dithered on this. heads() on graph is easy to check, so I'll add some
> tests for that from johns heads patch which was rejected.

I'm really sorry about this, but when I meant "it would be nice to test
Inventory.parent_candidates".  It should be fairly easy to test.

That said, the added test coverage is certainly welcome.

> I have not:
>  - made the ordering of per-file graph parents deterministic. I'll look
> at this as the commit refactoring progresses.

AIUI, this is no worse than current, so that's fine.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG3VRA0F+nu1YWqI0RAuVrAJ4hEViP4lq+PYJUIe8LmuqXO+2gfQCfQV6r
UONIEKPOCoWRQBZv3MWq8nk=
=vF6J
-----END PGP SIGNATURE-----



More information about the bazaar mailing list