[MERGE] Give nicer errors for some write operations on read-only transports.
jw+debian at jameswestby.net
Mon Sep 3 22:54:54 BST 2007
On (04/09/07 07:44), Robert Collins wrote:
> On Mon, 2007-09-03 at 22:39 +0100, James Westby wrote:
> > As I understand it your aversion to "look before you leap" was for
> > performance issues, but I don't think that would make a big enough
> > impact here to rule out a change that will hopefully help confused new
> > users find out what they need to do to solve their problem.
> If you consider webdav where 'is_readonly' requires a round trip to
> establish writability, you're adding (for me) 300ms to write operations
> that succeed - which is the common case.
Which is not in the core? That is all I checked before sending this
patch, so I missed it I'm afraid.
> > I will look in to catching and throwing exceptions, but I don't want to
> > get to a situation where we attempt to suggest users consider the
> > transport they are using when they try and push to a read-only
> > directory. This will depend on the exceptions that are currently thrown,
> > and it is not very consistent currently.
> This paragraph suggests a route to fix the problem :)
Indeed it does. However I am not sure I can commit to making that fix,
so I propose the current one as an interim solution. I will look in to
the other solution as this one is rejected.
James Westby -- GPG Key ID: B577FE13 -- http://jameswestby.net/
seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256
More information about the bazaar