[MERGE][#107155] _get_vendor_by_inspection incorrectly determines "plink" to be the executable

Martin Pool mbp at canonical.com
Fri Aug 31 06:10:04 BST 2007


Martin Pool has voted tweak.
Status is now: Semi-approved
Comment:

-    def _get_vendor_by_version_string(self, version):
+    def _get_vendor_by_version_string(self, version, arg):
          """Return the vendor or None based on output from the 
subprocess.

          :param version: The output of 'ssh -V' like command.
+        :param arg: Argument executed.
          """

Thanks Martin, that looks like it will do it.  My only comment is that 
the parameter could be called 'args' inside the method as it is in the 
caller and have a better docstring.  I can fix that and merge it if 
someone else will rereview.

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C2422be180708301335x3103b2c9mbaf318e287b4cf3b%40mail.gmail.com%3E



More information about the bazaar mailing list