[MERGE] 'send' and 'bundle' now handle partial ranges correctly (#61685)

Aaron Bentley aaron.bentley at utoronto.ca
Wed Aug 29 16:44:38 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> Am Freitag, den 24.08.2007, 16:34 -0400 schrieb Aaron Bentley:
>> This fixes a bug in bundle that caused partial revision ranges to be
>> handled incorrectly.  By partial ranges, I mean values like "-r5.." and
>> "-r..5".
>>
>> This patch causes the appropriate default to be selected when a partial
>> range is supplied.
> BB:approve

Thanks.

> What's the policy on when the size of tests? I would personally split up
> test_omitted_revision.

Wow, you're hardcore.

I don't see any guidance in HACKING.

For me, if a test is  testing two different things in the same place, or
if it's more than a screenful, I'd tend to split it up.  I don't see
anything wrong with testing a few different variations of the same
command in the same place, though.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG1ZRm0F+nu1YWqI0RAtYJAJ9IUUiFl96UR6WBXk6imi+x3jVI/wCePqc7
paLTXMAQ2n4jYVM18g7+r1M=
=+tds
-----END PGP SIGNATURE-----



More information about the bazaar mailing list