why does has_same_location check the class?

Martin Pool mbp at sourcefrog.net
Wed Aug 29 02:51:24 BST 2007


At the moment in bzr.dev the has_same_location implementation checks
that the two objects are of the same class and that they have the same
location.  The first part of this has caused some failures in the
pack/inventory work because it the vfs-based repository used by a
RemoteRepository to be seen as having a different location.  And
anyhow, it's a bit inconsistent with the name.

Is there any reason to keep this check?

Also, at the moment Repository, Branch, WorkingTree are all subclasses
of object.  There is some common behaviour between them that could
usefully be split into a base class, maybe called "Component" (of a
BzrDir).  Any comments, objections, or better names?

-- 
Martin



More information about the bazaar mailing list