[MERGE][Bug #52479] Message at the end of commit for bound branches

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Watkins wrote:
> On Sun, 2007-08-26 at 10:14 -0400, Aaron Bentley wrote:
>> I'd appreciate more rationale in your merge requests.  I don't see 
>> anything fundamentally different between bound and unbound branches 
>> here.  If we're going to show the location, why not show it always?
> I was fixing the bug

There's a big difference between bugs and feature requests.  Feature
requests have a much greater potential for differences of opinion, so I
always recommend hashing them out on the mailing list.  For example:

- - A person might think this feature would add too much clutter to commit
messages
- - A person might think that this feature doesn't adequately inform
people when they make an accidental local commit
- - A person might think that this feature is no longer necessary now that
'bzr info' provides information about where commits will go
- - A person might think that this output isn't very useful, because it
requires the person to remember the location of the master branch
- - A person might think that people should be informed at the beginning
of the commit, not the end.

Also, this feature request is more than a year old, so it might not
apply any more.  We've come a long way from 0.8.

For all those reasons, you should look at feature requests and decide
what *you* think about them.  Do they still apply?  Are they a good
idea?  Are there better solutions to the problem?

For example, what about printing 'Committed revision x (local)' and
'Committed revision x (master)'?  That's a lot shorter, and it doesn't
require the user to remember which URL is which.

So please don't defer to the bug for an explanation.  I'm not asking for
a big rationale, but something like "This is to help users who may be
unclear whether they are committing locally or committing to a bound
branch" would help me assess the change.

Your create-tree merge request was particularly confusing in this
regard, as the changes didn't even match the subject line.

> As for
> rationale beyond that, I suppose my assumption is that any given commit
> is local and so the location only need be displayed when a helpful
> reminder that this is not the case is needed.

I am not sure whether new users would grasp this intuitively, and I
suspect this feature is primarily aimed at new users.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG0dnk0F+nu1YWqI0RAvg5AJ0co/8HLsh8ijbZNCDh/B7kD2lPDgCfaULS
c7jL3UuOm0JII6cWgg8Pp0k=
=ODRs
-----END PGP SIGNATURE-----